[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 01/17] pci: fix unaligned access in pci_xxx_q
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PATCH v6 01/17] pci: fix unaligned access in pci_xxx_quad() |
|
Date: |
Mon, 30 May 2016 18:26:09 +0300 |
On Mon, May 30, 2016 at 06:22:35PM +0300, Dmitry Fleytman wrote:
>
> > On 30 May 2016, at 18:19 PM, Michael S. Tsirkin <address@hidden> wrote:
> >
> > On Mon, May 30, 2016 at 06:14:56PM +0300, Dmitry Fleytman wrote:
> >> Does DSN generation function pass unaligned offsets?
> >> It does not look like it does…
> >>
> >>
> >> It does according to clang sanitiser.
> >
> >
> > Oh so it's a clang false positive?
>
> I think not.
> The capability itself is 8-bytes aligned but 64-bit serial number inside of
> it is not because of 32 bit header in front of it.
Oh right. Things like this should really go into commit log
in the future.
For now a code comment in pci set/get that explains that
alignment in capabilities is generally at dword not qword
boundary would be enough.
> >
> > --
> > MST
- [Qemu-devel] [PATCH v6 00/17] Introduce Intel 82574 GbE Controller Emulation (e1000e), Leonid Bloch, 2016/05/30
- [Qemu-devel] [PATCH v6 01/17] pci: fix unaligned access in pci_xxx_quad(), Leonid Bloch, 2016/05/30
- Re: [Qemu-devel] [PATCH v6 01/17] pci: fix unaligned access in pci_xxx_quad(), Michael S. Tsirkin, 2016/05/30
- Re: [Qemu-devel] [PATCH v6 01/17] pci: fix unaligned access in pci_xxx_quad(), Dmitry Fleytman, 2016/05/30
- Re: [Qemu-devel] [PATCH v6 01/17] pci: fix unaligned access in pci_xxx_quad(), Michael S. Tsirkin, 2016/05/30
- Re: [Qemu-devel] [PATCH v6 01/17] pci: fix unaligned access in pci_xxx_quad(), Dmitry Fleytman, 2016/05/30
- Re: [Qemu-devel] [PATCH v6 01/17] pci: fix unaligned access in pci_xxx_quad(), Michael S. Tsirkin, 2016/05/30
- Re: [Qemu-devel] [PATCH v6 01/17] pci: fix unaligned access in pci_xxx_quad(), Dmitry Fleytman, 2016/05/30
- Re: [Qemu-devel] [PATCH v6 01/17] pci: fix unaligned access in pci_xxx_quad(),
Michael S. Tsirkin <=
[Qemu-devel] [PATCH v6 04/17] pcie: Add support for PCIe CAP v1, Leonid Bloch, 2016/05/30
[Qemu-devel] [PATCH v6 03/17] pci: Introduce define for PM capability version 1.1, Leonid Bloch, 2016/05/30
[Qemu-devel] [PATCH v6 05/17] pcie: Introduce function for DSN capability creation, Leonid Bloch, 2016/05/30
[Qemu-devel] [PATCH v6 02/17] msix: make msix_clr_pending() visible for clients, Leonid Bloch, 2016/05/30
[Qemu-devel] [PATCH v6 06/17] vmxnet3: Use generic function for DSN capability definition, Leonid Bloch, 2016/05/30
[Qemu-devel] [PATCH v6 08/17] net: Add macros for MAC address tracing, Leonid Bloch, 2016/05/30
[Qemu-devel] [PATCH v6 09/17] vmxnet3: Use common MAC address tracing macros, Leonid Bloch, 2016/05/30
[Qemu-devel] [PATCH v6 11/17] rtl8139: Move more TCP definitions to common header, Leonid Bloch, 2016/05/30
[Qemu-devel] [PATCH v6 07/17] net: Introduce Toeplitz hash calculator, Leonid Bloch, 2016/05/30
[Qemu-devel] [PATCH v6 13/17] vmxnet3: Use pci_dma_* API instead of cpu_physical_memory_*, Leonid Bloch, 2016/05/30