[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 04/15] Makefile: Rules for docker testing
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v6 04/15] Makefile: Rules for docker testing |
Date: |
Tue, 31 May 2016 14:48:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 31/05/2016 14:40, Fam Zheng wrote:
> > I'm still a bit undecided about the pollution introduced by
> > tests/docker/Makefile.include, but I guess that's okay.
>
> I think it's also okay to switch to "make -C tests/docker" for docker targets
> (so "make docker" becomes "make -C tests/docker help"), this way the top
> Makefile is not touched.
That would be a bit harder to discover. Go ahead with your current
solution. Perhaps rename SRC_COPY to DOCKER_SRC_COPY?
Thanks,
Paolo
[Qemu-devel] [PATCH v6 05/15] docker: Add images, Fam Zheng, 2016/05/27
[Qemu-devel] [PATCH v6 08/15] docker: Add quick test, Fam Zheng, 2016/05/27
[Qemu-devel] [PATCH v6 09/15] docker: Add full test, Fam Zheng, 2016/05/27
[Qemu-devel] [PATCH v6 07/15] docker: Add common.rc, Fam Zheng, 2016/05/27
[Qemu-devel] [PATCH v6 06/15] docker: Add test runner, Fam Zheng, 2016/05/27
[Qemu-devel] [PATCH v6 10/15] docker: Add clang test, Fam Zheng, 2016/05/27
[Qemu-devel] [PATCH v6 11/15] docker: Add mingw test, Fam Zheng, 2016/05/27
[Qemu-devel] [PATCH v6 14/15] docker: Add EXTRA_CONFIGURE_OPTS, Fam Zheng, 2016/05/27
[Qemu-devel] [PATCH v6 13/15] docs: Add text for tests/docker in build-system.txt, Fam Zheng, 2016/05/27