Re: [Qemu-devel] [RFC v2 PATCH 07/13] tcg/ppc: Add support for fence

[Richard Henderson]

On 05/31/2016 11:39 AM, Pranith Kumar wrote:
> +#define HWSYNC XO31(598)
> +#define LWSYNC (HWSYNC | (1u << 21))
...
> +    case INDEX_op_mb:
> +        /* ??? Do we want SEQ_CST or ACQ_REL memory model.  */
> +        tcg_out32(s, HWSYNC);
> +        break;

With the flags argument, this needs to be

#define EIEIO  XO31(854)

        a0 = args[0];
        if (a0 == TCG_MB_WRITE) {
                tcg_out32(s, EIEIO);
        } else if (a1 == TCG_MB_READ) {
                tcg_out32(s, LWSYNC);
        } else {
                tcg_out32(s, HWSYNC);
        }


r~