qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 04/15] Makefile: Rules for docker testing


From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH v6 04/15] Makefile: Rules for docker testing
Date: Wed, 1 Jun 2016 10:26:12 +0800
User-agent: Mutt/1.6.1 (2016-04-27)

On Tue, 05/31 14:48, Paolo Bonzini wrote:
> 
> 
> On 31/05/2016 14:40, Fam Zheng wrote:
> > > I'm still a bit undecided about the pollution introduced by
> > > tests/docker/Makefile.include, but I guess that's okay.
> > 
> > I think it's also okay to switch to "make -C tests/docker" for docker 
> > targets
> > (so "make docker" becomes "make -C tests/docker help"), this way the top
> > Makefile is not touched.
> 
> That would be a bit harder to discover.  Go ahead with your current
> solution.  Perhaps rename SRC_COPY to DOCKER_SRC_COPY?

OK, good idea.

Fam



reply via email to

[Prev in Thread] Current Thread [Next in Thread]