[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ui: sdl2: Fix crash with -nodefaults -sdl
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH] ui: sdl2: Fix crash with -nodefaults -sdl |
Date: |
Wed, 01 Jun 2016 08:39:07 +0200 |
On Di, 2016-05-31 at 22:49 +0100, Peter Maydell wrote:
> On 31 May 2016 at 21:56, Cole Robinson <address@hidden> wrote:
> > $ ./x86_64-softmmu/qemu-system-x86_64 -nodefaults -sdl
> > Segmentation fault (core dumped)
> >
> > 0 0x00005555559631af in sdl_display_init (ds=<optimized out>,
> > full_screen=0, no_frame=<optimized out>) at ui/sdl2.c:822
> > 1 0x00005555556c8a9a in main (argc=<optimized out>, argv=<optimized out>,
> > envp=<optimized out>) at vl.c:4527
> >
> > Setting the window icon assumes there's always an SDL output window
> > available, which isn't the case with when there's no video device,
> > like via -nodefaults. So don't try to set a window icon when we don't
> > have any outputs.
>
> Presumably we also crash for boards like the arm 'virt'
> which just don't have a display device at all...
There are still the vc's for monitor and serial.
cheers,
Gerd