[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/char: QOM'ify escc.c (fix)
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] hw/char: QOM'ify escc.c (fix) |
Date: |
Wed, 1 Jun 2016 15:13:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 01/06/2016 14:33, Mark Cave-Ayland wrote:
> > +
> > + memory_region_init_io(&s->mmio, OBJECT(dev), &escc_mem_ops, s, "escc",
> > + ESCC_SIZE << s->it_shift);
> > +
> > for (i = 0; i < 2; i++) {
> > if (s->chn[i].chr) {
> > + s->chn[i].clock = s->frequency / 2;
>
> Should this not still be in escc_init1() since s->frequency is set by a
> property?
It's the other way round, escc_init1 is for things that do _not_ depend
on property values. So I think this should be fine.
Thanks,
Paolo