[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] e1000e: Fix build with ust trace backend
From: |
Dmitry Fleytman |
Subject: |
Re: [Qemu-devel] [PATCH] e1000e: Fix build with ust trace backend |
Date: |
Sat, 4 Jun 2016 10:03:45 +0300 |
> On 3 Jun 2016, at 16:47 PM, Peter Maydell <address@hidden> wrote:
>
> On 3 June 2016 at 12:03, Peter Maydell <address@hidden> wrote:
>> Thanks, applied to master as a build fix.
>
> ...which reveals another build issue:
>
> https://travis-ci.org/qemu/qemu/jobs/135006245
>
> hw/net/e1000e.c: In function ‘e1000e_io_write’:
> hw/net/e1000e.c:170:39: error: ‘idx’ may be used uninitialized in this
> function [-Werror=uninitialized]
> hw/net/e1000e.c: In function ‘e1000e_io_read’:
> hw/net/e1000e.c:145:35: error: ‘idx’ may be used uninitialized in this
> function [-Werror=uninitialized]
>
> Combination of ust tracing backend plus gcc 4.6.3
> having a tendency to used-uninitialized false positives?
>
> The code itself looks fine so I think this is going to be
> a case of adding an initialization somewhere to shut the
> compiler up.
Hi Peter,
I just sent patch to fix this to the mailing list.
Regards,
Dmitry
>
> thanks
> -- PMM