|
From: | Cao jin |
Subject: | Re: [Qemu-devel] [PATCH v7 12/15] pci: Convert msi_init() to Error and fix callers to check it |
Date: | Mon, 6 Jun 2016 16:30:22 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 06/06/2016 04:00 PM, Cao jin wrote:
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
+ if (xhci->msi != ON_OFF_AUTO_OFF) { + ret = msi_init(dev, 0x70, xhci->numintrs, true, false, &err); + /* Any error other than -ENOTSUP(board's MSI support is broken) + * is a programming error */ + assert(!ret || ret == -ENOTSUP); + if (ret && xhci->msi == ON_OFF_AUTO_ON) { + /* Can't satisfy user's explicit msi=on request, fail */ + error_append_hint(&err, "You have to use msi=auto (default) or " + "si=off with this machine type.\n");
sorry, I made a typo "si=off", maybe it could be fixed when be applied by maintainer
-- Yours Sincerely, Cao jin
[Prev in Thread] | Current Thread | [Next in Thread] |