[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 11/14] console: add dpy_gl_scanout2()
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [RFC 11/14] console: add dpy_gl_scanout2() |
Date: |
Mon, 6 Jun 2016 09:18:27 -0400 (EDT) |
Hi
----- Original Message -----
> Hi,
>
> > @@ -218,6 +218,11 @@ typedef struct DisplayChangeListenerOps {
> > void (*dpy_gl_scanout)(DisplayChangeListener *dcl,
> > uint32_t backing_id, bool backing_y_0_top,
> > uint32_t x, uint32_t y, uint32_t w, uint32_t
> > h);
> > + void (*dpy_gl_scanout2)(DisplayChangeListener *dcl,
> > + int fd, bool backing_y_0_top,
> > + uint32_t x, uint32_t y, uint32_t w, uint32_t
> > h,
> > + uint32_t fd_w, uint32_t fd_h, uint32_t
> > fd_stride,
> > + int fd_fourcc);
>
> Interface looks sane. I'd like to see a more descriptive name than just
> "2" though. Maybe "dpy_gl_scanout_dmabuf"? And while being at it
> rename the other one to "dpy_gl_scanout_texture"?
sounds good
>
> Also: please put the spice update into a separate patch.
ok
>
> Adding gtk (or sdl2, or both) support would be nice, to see whenever the
> interface works if qemu needs to import the dma-buf for display.
As I explained in cover, it's not easily doable since gtk/sdl2 use glx, and
can't import dmabuf (it needs egl). I could make it work with gtk/egl (but not
gtkglarea, sigh, so many UIs and subtle issues)
- [Qemu-devel] [RFC 00/14] vhost-user backends for gpu & input virtio devices, marcandre . lureau, 2016/06/04
- [Qemu-devel] [RFC 02/14] Add vhost-user-backend, marcandre . lureau, 2016/06/04
- [Qemu-devel] [RFC 03/14] vhost-user: split vhost_user_read(), marcandre . lureau, 2016/06/04
- [Qemu-devel] [RFC 01/14] Add qemu_chr_open_socket(), marcandre . lureau, 2016/06/04
- [Qemu-devel] [RFC 07/14] misc: rename virtio-gpu.h header guard, marcandre . lureau, 2016/06/04
- [Qemu-devel] [RFC 04/14] vhost-user: add vhost_user_input_get_config(), marcandre . lureau, 2016/06/04
- [Qemu-devel] [RFC 09/14] qemu-char: use READ_RETRIES, marcandre . lureau, 2016/06/04
- [Qemu-devel] [RFC 11/14] console: add dpy_gl_scanout2(), marcandre . lureau, 2016/06/04
- [Qemu-devel] [RFC 05/14] Add vhost-user backend to virtio-input-host, marcandre . lureau, 2016/06/04
- [Qemu-devel] [RFC 08/14] vhost: make sure call fd has been received, marcandre . lureau, 2016/06/04
- [Qemu-devel] [RFC 06/14] contrib: add vhost-user-input, marcandre . lureau, 2016/06/04
- [Qemu-devel] [RFC 10/14] qemu-char: block during sync read, marcandre . lureau, 2016/06/04
- [Qemu-devel] [RFC 12/14] contrib: add vhost-user-gpu, marcandre . lureau, 2016/06/04
- [Qemu-devel] [RFC 13/14] vhost-user: add vhost_user_gpu_set_socket(), marcandre . lureau, 2016/06/04
- [Qemu-devel] [RFC 14/14] Add virtio-gpu vhost-user backend, marcandre . lureau, 2016/06/04