[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] Makefile: add dependency on scripts/create_
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] Makefile: add dependency on scripts/create_config |
Date: |
Tue, 7 Jun 2016 14:11:55 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 07/06/2016 14:09, Peter Maydell wrote:
> On 7 June 2016 at 13:05, Paolo Bonzini <address@hidden> wrote:
>>
>>
>> On 07/06/2016 13:58, Peter Maydell wrote:
>>> Does it work to add the dependency on the RHS of the pattern rule
>>> instead, like:
>>>
>>> config-%.h-timestamp: config-%.mak $(SRC_PATH)/scripts/create_config
>>> $(call quiet-command, sh $(SRC_PATH)/scripts/create_config <
>>> $< > $@, " GEN $(TARGET_DIR)config-$*.h")
>>
>> Yes, that works too.
>
> Cool -- I think it's a bit clearer to add the dependency
> in the same place where the rule text invoking the script is.
I agree, I've sent v2.
Paolo
[Qemu-devel] [PATCH 2/3] Makefile: add dependency on scripts/make_device_config.sh, Paolo Bonzini, 2016/06/07
[Qemu-devel] [PATCH 3/3] Makefile: add dependency on scripts/hxtool, Paolo Bonzini, 2016/06/07