[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 14/22] mirror: Disable image locking on targe
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v6 14/22] mirror: Disable image locking on target backing chain |
Date: |
Wed, 8 Jun 2016 11:22:45 +0800 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Mon, 06/06 17:03, Max Reitz wrote:
> On 03.06.2016 10:49, Fam Zheng wrote:
> > In sync=none the backing image of s->target is s->common.bs, which could
> > be exclusively locked, the image locking wouldn't work here.
> >
> > Later we can update completion code to lock it after the replaced node
> > has dropped its lock.
> >
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> > blockdev.c | 10 ++++++++--
> > 1 file changed, 8 insertions(+), 2 deletions(-)
>
> Without having reviewed the patch in the new context, when basing your
> series on v2 of my "block/mirror: Fix target backing BDS​", all iotests
> pass even without this patch.
>
> Without my series, test 041 fails.
>
> So I have reason to hope that I was actually able to make this patch
> superfluous.
Great, then I can drop this patch from v7 later.
Fam
- [Qemu-devel] [PATCH v6 09/22] qemu-io: Add "-L" option for BDRV_O_NO_LOCK, (continued)
- [Qemu-devel] [PATCH v6 09/22] qemu-io: Add "-L" option for BDRV_O_NO_LOCK, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 06/22] osdep: Introduce qemu_dup, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 08/22] raw-posix: Add image locking support, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 12/22] qemu-nbd: Add "--no-lock/-L" option, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 10/22] qemu-img: Add "-L" option to sub commands, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 13/22] block: Don't lock drive-backup target image in none mode, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 11/22] qemu-img: Update documentation of "-L" option, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 14/22] mirror: Disable image locking on target backing chain, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 17/22] qemu-iotests: 030: Disable image locking when checking test image, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 16/22] qemu-iotests: Wait for QEMU processes before checking image in 091, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 15/22] qemu-iotests: 046: Move version detection out from verify_io, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 18/22] iotests: 087: Disable image locking in cases where file is shared, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 19/22] iotests: Disable image locking in 085, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 20/22] tests: Use null-co:// instead of /dev/null, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 21/22] block: Turn on image locking by default, Fam Zheng, 2016/06/03
- [Qemu-devel] [PATCH v6 22/22] qemu-iotests: Add test case 153 for image locking, Fam Zheng, 2016/06/03