[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 00/13] NVDIMM: introduce nvdimm label support
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v3 00/13] NVDIMM: introduce nvdimm label support |
Date: |
Wed, 8 Jun 2016 14:07:34 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Tue, Jun 07, 2016 at 08:21:56PM +0800, Xiao Guangrong wrote:
> Changelog in v3:
> - introduce get_vmstate_memory_region() callback to abstract the difference
> between pc-dimm and nvdimm addressing Stefan's suggestion
>
> Changelog in v2:
> Thanks for Stefan's review, the changes in this version are:
> - rename nvdimm device parameter 'reserve-label' to 'label-size' to
> specify the size of label
> - add comment to explain why assert() used in nvdimm_assert_rw_label_data()
> is safe
> - follow the code style of 'foo() return;' if nothing is returned by fool()
> - fix the value of "Non-existing-Memory-Device"
> - fix the handling the DSM functions we currently did not support
>
>
> This patchset is against commit cc973937f47a33 (virtio: move bi-endian
> target support to a single location ) on pci branch of Michael's git tree
> and can be found at:
> https://github.com/xiaogr/qemu.git nvdimm-label-v3
>
> This is the last part of vNVDIMM implementation which introduces nvdimm
> label support
>
> Currently Linux NVDIMM driver does not support namespace operation on this
> kind of PMEM, apply below changes to support dynamical namespace:
>
> @@ -798,7 +823,8 @@ static int acpi_nfit_register_dimms(struct acpi_nfit_desc
> *a
> continue;
> }
>
> - if (nfit_mem->bdw && nfit_mem->memdev_pmem)
> + //if (nfit_mem->bdw && nfit_mem->memdev_pmem)
> + if (nfit_mem->memdev_pmem)
> flags |= NDD_ALIASING;
>
> Xiao Guangrong (13):
> pc-dimm: introduce get_vmstate_memory_region callback
> nvdimm: support nvdimm label
> acpi: add aml_object_type
> acpi: add aml_call5
> nvdimm acpi: set HDLE properly
> nvdimm acpi: save arg3 of _DSM method
> nvdimm acpi: check UUID
> nvdimm acpi: abstract the operations for root & nvdimm devices
> nvdimm acpi: check revision
> nvdimm acpi: support Get Namespace Label Size function
> nvdimm acpi: support Get Namespace Label Data function
> nvdimm acpi: support Set Namespace Label Data function
> docs: add NVDIMM ACPI documentation
>
> docs/specs/acpi_nvdimm.txt | 132 +++++++++++++++
> hw/acpi/aml-build.c | 22 +++
> hw/acpi/nvdimm.c | 400
> ++++++++++++++++++++++++++++++++++++++++----
> hw/mem/nvdimm.c | 132 +++++++++++++++
> hw/mem/pc-dimm.c | 14 +-
> include/hw/acpi/aml-build.h | 3 +
> include/hw/mem/nvdimm.h | 55 +++++-
> include/hw/mem/pc-dimm.h | 5 +-
> 8 files changed, 726 insertions(+), 37 deletions(-)
> create mode 100644 docs/specs/acpi_nvdimm.txt
>
> --
> 1.8.3.1
>
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v3 02/13] nvdimm: support nvdimm label, (continued)
- [Qemu-devel] [PATCH v3 02/13] nvdimm: support nvdimm label, Xiao Guangrong, 2016/06/07
- [Qemu-devel] [PATCH v3 06/13] nvdimm acpi: save arg3 of _DSM method, Xiao Guangrong, 2016/06/07
- [Qemu-devel] [PATCH v3 05/13] nvdimm acpi: set HDLE properly, Xiao Guangrong, 2016/06/07
- [Qemu-devel] [PATCH v3 07/13] nvdimm acpi: check UUID, Xiao Guangrong, 2016/06/07
- [Qemu-devel] [PATCH v3 08/13] nvdimm acpi: abstract the operations for root & nvdimm devices, Xiao Guangrong, 2016/06/07
- [Qemu-devel] [PATCH v3 11/13] nvdimm acpi: support Get Namespace Label Data function, Xiao Guangrong, 2016/06/07
- [Qemu-devel] [PATCH v3 09/13] nvdimm acpi: check revision, Xiao Guangrong, 2016/06/07
- [Qemu-devel] [PATCH v3 10/13] nvdimm acpi: support Get Namespace Label Size function, Xiao Guangrong, 2016/06/07
- [Qemu-devel] [PATCH v3 12/13] nvdimm acpi: support Set Namespace Label Data function, Xiao Guangrong, 2016/06/07
- [Qemu-devel] [PATCH v3 13/13] docs: add NVDIMM ACPI documentation, Xiao Guangrong, 2016/06/07
- Re: [Qemu-devel] [PATCH v3 00/13] NVDIMM: introduce nvdimm label support,
Stefan Hajnoczi <=