Re: [Qemu-devel] [PATCH v2 2/6] target-i386: print obsolete warnings if +-features are used

[Eduardo Habkost]

On Thu, Jun 09, 2016 at 07:10:59PM +0200, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <address@hidden>

Applied to x86-next after changing it to use error_report().

> ---
>  target-i386/cpu.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 947cf18..3f886a5 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1979,9 +1979,15 @@ static void x86_cpu_parse_featurestr(CPUState *cs, 
> char *features,
>          /* Compatibility syntax: */
>          if (featurestr[0] == '+') {
>              add_flagname_to_bitmaps(featurestr + 1, plus_features, 
> &local_err);
> +            fprintf(stderr,
> +                "'+%s' is obsolete and will be removed in future, use 
> '%s=on'",
> +                featurestr + 1, featurestr + 1);
>              continue;
>          } else if (featurestr[0] == '-') {
>              add_flagname_to_bitmaps(featurestr + 1, minus_features, 
> &local_err);
> +            fprintf(stderr,
> +                "'-%s' is obsolete and will be removed in future, use 
> '%s=off'",
> +                featurestr + 1, featurestr + 1);
>              continue;
>          }
>  
> -- 
> 2.7.0
> 

-- 
Eduardo