[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 11/17] msi_init: change return value to 0 on succ
From: |
Cao jin |
Subject: |
[Qemu-devel] [PATCH v8 11/17] msi_init: change return value to 0 on success |
Date: |
Fri, 10 Jun 2016 17:54:32 +0800 |
No caller use its return value as msi capability offset, also in order
to make its return behaviour consistent with msix_init().
cc: Michael S. Tsirkin <address@hidden>
cc: Paolo Bonzini <address@hidden>
cc: Hannes Reinecke <address@hidden>
cc: Markus Armbruster <address@hidden>
cc: Marcel Apfelbaum <address@hidden>
Acked-by: Hannes Reinecke <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Cao jin <address@hidden>
---
hw/pci/msi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Hi Hannes,
This version changed, If is ok with you, I will let your A-b still here.
diff --git a/hw/pci/msi.c b/hw/pci/msi.c
index 359058e..ed79225 100644
--- a/hw/pci/msi.c
+++ b/hw/pci/msi.c
@@ -173,8 +173,7 @@ bool msi_enabled(const PCIDevice *dev)
* If @msi64bit, make the device capable of sending a 64-bit message
* address.
* If @msi_per_vector_mask, make the device support per-vector masking.
- * Return the offset of capability MSI in config space on success,
- * return -errno on error.
+ * Return 0 on success, return -errno on error.
*
* -ENOTSUP means lacking msi support for a msi-capable platform.
* -EINVAL means capability overlap, happens when @offset is non-zero,
@@ -236,7 +235,8 @@ int msi_init(struct PCIDevice *dev, uint8_t offset,
pci_set_long(dev->wmask + msi_mask_off(dev, msi64bit),
0xffffffff >> (PCI_MSI_VECTORS_MAX - nr_vectors));
}
- return config_offset;
+
+ return 0;
}
void msi_uninit(struct PCIDevice *dev)
--
2.1.0
- [Qemu-devel] [PATCH v8 00/17] Add param Error ** for msi_init(), Cao jin, 2016/06/10
- [Qemu-devel] [PATCH v8 03/17] change pvscsi_init_msi() type to void, Cao jin, 2016/06/10
- [Qemu-devel] [PATCH v8 04/17] megasas: Fix check for msi_init() failure, Cao jin, 2016/06/10
- [Qemu-devel] [PATCH v8 09/17] megasas: change msi/msix property type, Cao jin, 2016/06/10
- [Qemu-devel] [PATCH v8 05/17] mptsas: change .realize function name, Cao jin, 2016/06/10
- [Qemu-devel] [PATCH v8 06/17] usb xhci: change msi/msix property type, Cao jin, 2016/06/10
- [Qemu-devel] [PATCH v8 02/17] fix some coding style problems, Cao jin, 2016/06/10
- [Qemu-devel] [PATCH v8 11/17] msi_init: change return value to 0 on success,
Cao jin <=
- [Qemu-devel] [PATCH v8 07/17] intel-hda: change msi property type, Cao jin, 2016/06/10
- [Qemu-devel] [PATCH v8 01/17] pci core: assert ENOSPC when add capability, Cao jin, 2016/06/10
- [Qemu-devel] [PATCH v8 14/17] mptsas: remove unnecessary internal msi state flag, Cao jin, 2016/06/10
- [Qemu-devel] [PATCH v8 12/17] pci: Convert msi_init() to Error and fix callers to check it, Cao jin, 2016/06/10