[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 08/17] mptsas: change msi property type
From: |
Cao jin |
Subject: |
[Qemu-devel] [PATCH v8 08/17] mptsas: change msi property type |
Date: |
Fri, 10 Jun 2016 17:54:29 +0800 |
>From uint32 to enum OnOffAuto, and give it a shorter name.
cc: Paolo Bonzini <address@hidden>
cc: Michael S. Tsirkin <address@hidden>
cc: Markus Armbruster <address@hidden>
cc: Marcel Apfelbaum <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Cao jin <address@hidden>
---
hw/scsi/mptsas.c | 5 +++--
hw/scsi/mptsas.h | 3 ++-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c
index ae8514e..dfbc0c4 100644
--- a/hw/scsi/mptsas.c
+++ b/hw/scsi/mptsas.c
@@ -1284,8 +1284,9 @@ static void mptsas_scsi_realize(PCIDevice *dev, Error
**errp)
memory_region_init_io(&s->diag_io, OBJECT(s), &mptsas_diag_ops, s,
"mptsas-diag", 0x10000);
- if (s->msi_available &&
+ if (s->msi != ON_OFF_AUTO_OFF &&
msi_init(dev, 0, 1, true, false) >= 0) {
+ /* TODO check for errors */
s->msi_in_use = true;
}
@@ -1403,7 +1404,7 @@ static const VMStateDescription vmstate_mptsas = {
static Property mptsas_properties[] = {
DEFINE_PROP_UINT64("sas_address", MPTSASState, sas_addr, 0),
/* TODO: test MSI support under Windows */
- DEFINE_PROP_BIT("msi", MPTSASState, msi_available, 0, true),
+ DEFINE_PROP_ON_OFF_AUTO("msi", MPTSASState, msi, ON_OFF_AUTO_AUTO),
DEFINE_PROP_END_OF_LIST(),
};
diff --git a/hw/scsi/mptsas.h b/hw/scsi/mptsas.h
index 595f81f..0436a33 100644
--- a/hw/scsi/mptsas.h
+++ b/hw/scsi/mptsas.h
@@ -27,7 +27,8 @@ struct MPTSASState {
MemoryRegion diag_io;
QEMUBH *request_bh;
- uint32_t msi_available;
+ /* properties */
+ OnOffAuto msi;
uint64_t sas_addr;
bool msi_in_use;
--
2.1.0
- Re: [Qemu-devel] [PATCH v8 11/17] msi_init: change return value to 0 on success, (continued)
[Qemu-devel] [PATCH v8 08/17] mptsas: change msi property type,
Cao jin <=
[Qemu-devel] [PATCH v8 10/17] pci bridge dev: change msi property type, Cao jin, 2016/06/10
[Qemu-devel] [PATCH v8 15/17] vmw_pvscsi: remove unnecessary internal msi state flag, Cao jin, 2016/06/10
[Qemu-devel] [PATCH v8 17/17] e1000e: remove unnecessary internal msi state flag, Cao jin, 2016/06/10
[Qemu-devel] [PATCH v8 16/17] vmxnet3: remove unnecessary internal msi state flag, Cao jin, 2016/06/10