Re: [Qemu-devel] [RFC] Allow AMD IOMMU to have both SysBusDevice and PCIDevice properties.

[David Kiarie]

On Thu, Jun 9, 2016 at 4:23 PM, Marcel Apfelbaum <address@hidden> wrote:
> On 06/07/2016 10:12 PM, Eduardo Habkost wrote:
>>
>> Hi,
>>
>
> [...]
>
>> [...]
>>>
>>> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
>>> index 04aae89..431eaed 100644
>>> --- a/hw/i386/pc_q35.c
>>> +++ b/hw/i386/pc_q35.c
>>> @@ -281,6 +281,7 @@ static void pc_q35_machine_options(MachineClass *m)
>>>       m->default_machine_opts = "firmware=bios-256k.bin";
>>>       m->default_display = "std";
>>>       m->no_floppy = 1;
>>> +    m->has_dynamic_sysbus = true;
>>
>>
>> Why is this needed? Is it possible to do this change before
>> adding the iommu code?  Can this be done in a separate patch that
>> documents why it should be changed and why it is safe to set it
>> to true?
>>
>>>
>
> Hi Eduardo,
>
> I also have this change as part of '[PATCH v2 0/3] enable iommu with
> -device'.
>
> Please see:
> https://www.mail-archive.com/address@hidden/msg374644.html

This change is actually yours. My code is depends on your code.

>
>
> Thanks,
> Marcel