qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Call cmp with "-s" instead of "--quiet"


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] Call cmp with "-s" instead of "--quiet"
Date: Sat, 11 Jun 2016 14:42:48 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 06/11/2016 11:15 AM, Sean Bruno wrote:
> 
> 
> --quiet isn't available on FreeBSD and doesn't seem to be used in
> other places.  This fixes some non-fatal build errors on FreeBSD.  The
> use of "-s" over "--quiet" seems to be the preferred use in the Makefile.
> 
> diff --git a/Makefile b/Makefile
> index ed4032a..a7a356a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -185,7 +185,7 @@ qemu-version.h: FORCE
>                                 printf '""\n'; \
>                         fi; \
>                 fi) > address@hidden)
> -       $(call quiet-command, cmp --quiet $@ address@hidden || mv 
> address@hidden $@)
> +       $(call quiet-command, cmp -s $@ address@hidden || mv address@hidden 
> $@)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]