Re: [Qemu-devel] [RESEND] [PATCH 0/6] virtio: refactor host notifiers

[Fam Zheng]

On Fri, 06/10 11:04, Cornelia Huck wrote:
> Hi,
> 
> this is a resend of the host notifier refactoring I last sent out
> on 2016/04/25. Just rebased on current master and pushed out to
> github.com/cohuck/qemu host-notifier-refactor.
> 
> Blurb from the last posting follows:
> 
> This still fixes an issue where we have no ioeventfd for a short
> time, but it does not break our necks any more with the recent
> fixes. Still, I think this is a net win, especially considering
> we remove a lot of similar code from the individual transports.

Agreed. And the changes look good to me, thanks.

Reviewed-by: Fam Zheng <address@hidden>

> 
> Cornelia Huck (6):
>   virtio-bus: common ioeventfd infrastructure
>   virtio-bus: have callers tolerate new host notifier api
>   virtio-ccw: convert to ioeventfd callbacks
>   virtio-pci: convert to ioeventfd callbacks
>   virtio-mmio: convert to ioeventfd callbacks
>   virtio-bus: remove old set_host_notifier callback
> 
>  hw/block/dataplane/virtio-blk.c |   6 +-
>  hw/s390x/virtio-ccw.c           | 133 
> ++++++++++++++--------------------------
>  hw/scsi/virtio-scsi-dataplane.c |   9 ++-
>  hw/virtio/vhost.c               |  13 ++--
>  hw/virtio/virtio-bus.c          | 132 +++++++++++++++++++++++++++++++++++++++
>  hw/virtio/virtio-mmio.c         | 128 +++++++++++++-------------------------
>  hw/virtio/virtio-pci.c          | 124 +++++++++++++------------------------
>  include/hw/virtio/virtio-bus.h  |  31 +++++++++-
>  8 files changed, 303 insertions(+), 273 deletions(-)
> 
> -- 
> 2.6.6
>