qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V3] net: fix qemu_announce_self not emitting pac


From: Jason Wang
Subject: Re: [Qemu-devel] [PATCH V3] net: fix qemu_announce_self not emitting packets
Date: Mon, 13 Jun 2016 10:56:18 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0



On 2016年06月09日 17:39, Peter Lieven wrote:
commit fefe2a78 accidently dropped the code path for injecting
raw packets. This feature is needed for sending gratuitous ARPs
after an incoming migration has completed. The result is increased
network downtime for vservers where the network card is not virtio-net
with the VIRTIO_NET_F_GUEST_ANNOUNCE feature.

Fixes: fefe2a78abde932e0f340b21bded2c86def1d242
Cc: address@hidden
Cc: address@hidden
Signed-off-by: Peter Lieven <address@hidden>
---
v1->v2: assert that only raw packets with a plain buffer come in. [Paolo]
v2->v3: nc_senv_compat can take care of raw packets [Paolo, Jason]

  net/net.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/net.c b/net/net.c
index 5f3e5a9..75bb177 100644
--- a/net/net.c
+++ b/net/net.c
@@ -722,7 +722,7 @@ ssize_t qemu_deliver_packet_iov(NetClientState *sender,
          return 0;
      }
- if (nc->info->receive_iov) {
+    if (nc->info->receive_iov && !(flags & QEMU_NET_PACKET_FLAG_RAW)) {
          ret = nc->info->receive_iov(nc, iov, iovcnt);
      } else {
          ret = nc_sendv_compat(nc, iov, iovcnt, flags);

Applied to -net. Thanks



reply via email to

[Prev in Thread] Current Thread [Next in Thread]