Re: [Qemu-devel] [PATCH] Makefile: Fix tag file generation targets

[Paolo Bonzini]

On 09/06/2016 19:58, Sergey Fedorov wrote:
> From: Sergey Fedorov <address@hidden>
> 
> "ctags" produces a file named "tags", not "ctags". It doesn't look
> reasonable to use phony target name as a file name to remove. Just use
> exact file names to remove in "ctags" and "TAGS" target receipts.
> 
> Signed-off-by: Sergey Fedorov <address@hidden>
> Signed-off-by: Sergey Fedorov <address@hidden>
> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index b8563db68677..61bf1bf9e2bb 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -478,12 +478,12 @@ test speed: all
>  
>  .PHONY: ctags
>  ctags:
> -     rm -f $@
> +     rm -f tags
>       find "$(SRC_PATH)" -name '*.[hc]' -exec ctags --append {} +
>  
>  .PHONY: TAGS
>  TAGS:
> -     rm -f $@
> +     rm -f TAGS
>       find "$(SRC_PATH)" -name '*.[hc]' -exec etags --append {} +
>  
>  cscope:
> 

Queued, thanks.

Paolo