qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/10] ppc: Create cpu_ppc_set_papr() helper (fo


From: Cédric Le Goater
Subject: Re: [Qemu-devel] [PATCH 02/10] ppc: Create cpu_ppc_set_papr() helper (for LPCR)
Date: Tue, 14 Jun 2016 08:52:12 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.8.0

On 06/14/2016 08:15 AM, David Gibson wrote:
> On Mon, Jun 13, 2016 at 07:24:48AM +0200, Cédric Le Goater wrote:
>> From: Benjamin Herrenschmidt <address@hidden>
>>
>> And move the code adjusting the MSR mask and calling kvmppc_set_papr()
>> to it. This allows us to add a few more things such as disabling setting
>> of MSR:HV and appropriate LPCR bits which will be used when fixing
>> the exception model.
>>
>> Signed-off-by: Benjamin Herrenschmidt <address@hidden>
>> Reviewed-by: David Gibson <address@hidden>
>> [clg: previous commit 26a7f1291bb5 did not include the LPCR setting as
>>       it was not needed at the time ]
> 
> I see how this came about, but it means the commit message (both long
> and short) is confusingly mismatched from the code now.

OK. I will work on it.

For my education, how much can we change the initial changelog of a patch ?
Is it considered as part of the code ? 

Thanks,

C. 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]