Re: [Qemu-devel] [RFC v2 3/3] Remove unnecessary variables for function return value

[Markus Armbruster]

Eduardo Habkost <address@hidden> writes:

> On Mon, Jun 13, 2016 at 01:29:47PM +0200, Markus Armbruster wrote:
>> Eduardo Habkost <address@hidden> writes:
>> 
>> > Use Coccinelle script to replace 'ret = E; return ret' with
>> > 'return E'. The script will do the substitution only when the
>> > function return type and variable type are the same.
>> >
>> > Sending as RFC because the patch looks more intrusive than the
>> > others. Probably better to split it per subsystem and let each
>> > maintainer review and apply it?
>> 
>> As far as I'm concerned, obvious mechanical cleanups like this one can
>> go in as a single tree-wide patch.  I'd consider making you split it up,
>> then chase maintainers a waste of your time[*].
>
> Not wasting my time sounds like a good idea. :)
>
> Once the issues below are fixed and Eric's comments are
> addressed, should it go through your error reporting tree?

Yes.