[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/6] block: Don't enforce 512 byte minimum align
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 6/6] block: Don't enforce 512 byte minimum alignment |
Date: |
Tue, 14 Jun 2016 13:09:22 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Wed, Jun 08, 2016 at 04:10:11PM +0200, Kevin Wolf wrote:
> diff --git a/block.c b/block.c
> index f54bc25..3d850a2 100644
> --- a/block.c
> +++ b/block.c
> @@ -937,7 +937,7 @@ static int bdrv_open_common(BlockDriverState *bs,
> BdrvChild *file,
> goto fail_opts;
> }
>
> - bs->request_alignment = 512;
> + bs->request_alignment = drv->bdrv_co_preadv ? 1 : 512;
What happens in the raw-posix.c AIO case? There we should still use
512.
Stefan
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH 3/6] block: Prepare bdrv_aligned_pwritev() for byte-aligned requests, (continued)