[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/7] doc: move text describing --trace to specif
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/7] doc: move text describing --trace to specific .texi file |
Date: |
Tue, 14 Jun 2016 15:50:26 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 06/14/2016 03:49 PM, Eric Blake wrote:
> On 06/14/2016 04:08 AM, Denis V. Lunev wrote:
>> This text will be included to qemu-nbd/qemu-img mans in the next patches.
>>
>> Signed-off-by: Denis V. Lunev <address@hidden>
>> CC: Eric Blake <address@hidden>
>> CC: Paolo Bonzini <address@hidden>
>> CC: Stefan Hajnoczi <address@hidden>
>> CC: Kevin Wolf <address@hidden>
>> ---
>> Makefile | 3 ++-
>> qemu-option-trace.texi | 25 +++++++++++++++++++++++++
>> qemu-options.hx | 27 +--------------------------
>> 3 files changed, 28 insertions(+), 27 deletions(-)
>> create mode 100644 qemu-option-trace.texi
>
>> +++ b/qemu-options.hx
>> @@ -3669,32 +3669,7 @@ HXCOMM This line is not accurate, as some sub-options
>> are backend-specific but
>> HXCOMM HX does not support conditional compilation of text.
>> @item -trace address@hidden,address@hidden
>> @findex -trace
>
> As long as you are touching here, change the -trace line to match --help
> output:
>
> -trace [[enable=]<pattern>][,events=<file>][,file=<file>]
Nevermind - I see you do that in 2/7.
>
> With that change:
>
> Reviewed-by: Eric Blake <address@hidden>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v6 0/7] trace: enable tracing in qemu-io/qemu-nbd/qemu-img, Denis V. Lunev, 2016/06/14
- [Qemu-devel] [PATCH 1/7] doc: move text describing --trace to specific .texi file, Denis V. Lunev, 2016/06/14
- [Qemu-devel] [PATCH 2/7] doc: sync help descriprion for --trace with man for qemu.1, Denis V. Lunev, 2016/06/14
- [Qemu-devel] [PATCH 3/7] trace: move qemu_trace_opts to trace/control.c, Denis V. Lunev, 2016/06/14
- [Qemu-devel] [PATCH 6/7] qemu-img: move common options parsing before commands processing, Denis V. Lunev, 2016/06/14
- [Qemu-devel] [PATCH 4/7] trace: enable tracing in qemu-io, Denis V. Lunev, 2016/06/14
- [Qemu-devel] [PATCH 7/7] trace: enable tracing in qemu-img, Denis V. Lunev, 2016/06/14
- [Qemu-devel] [PATCH 5/7] trace: enable tracing in qemu-nbd, Denis V. Lunev, 2016/06/14