[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 01/40] trace: add build framework for merging
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v1 01/40] trace: add build framework for merging trace-events files |
Date: |
Tue, 14 Jun 2016 15:53:48 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 06/14/2016 06:26 AM, Stefan Hajnoczi wrote:
> On Thu, Jun 09, 2016 at 05:57:55PM +0100, Daniel P. Berrange wrote:
>> +$(BUILD_DIR)/trace-events-all: $(trace-events-y:%=$(SRC_PATH)/%)
>> + $(call quiet-command,cat $^ > $@)
>
> $^ needs to be a stable ordering across make invocations and across
> machines to avoid thrashing ccache and spuriously renumbering trace
> event IDs.
>
> I guess it is stable but just in case anyone knows of a case where $^
> would change order without any changes to the actual files (e.g.
> readdir(2) returning things in a different order, make parallel jobs,
> etc)...
As far as I can tell from 'info make', $^ is the list of prerequisites,
_in prerequisite order_, minus duplicates. So the only way the order
will change is if you edit Makefile, and thus it looks stable to me.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v1 00/40] Split up the trace-events file, Daniel P. Berrange, 2016/06/09
- [Qemu-devel] [PATCH v1 02/40] trace: split out trace events for util/ directory, Daniel P. Berrange, 2016/06/09
- [Qemu-devel] [PATCH v1 07/40] trace: split out trace events for hw/block/ directory, Daniel P. Berrange, 2016/06/09
- [Qemu-devel] [PATCH v1 04/40] trace: split out trace events for io/ directory, Daniel P. Berrange, 2016/06/09
- [Qemu-devel] [PATCH v1 06/40] trace: split out trace events for block/ directory, Daniel P. Berrange, 2016/06/09
- [Qemu-devel] [PATCH v1 08/40] trace: split out trace events for hw/char/ directory, Daniel P. Berrange, 2016/06/09
- [Qemu-devel] [PATCH v1 05/40] trace: split out trace events for migration/ directory, Daniel P. Berrange, 2016/06/09
- [Qemu-devel] [PATCH v1 11/40] trace: split out trace events for hw/virtio/ directory, Daniel P. Berrange, 2016/06/09
- [Qemu-devel] [PATCH v1 13/40] trace: split out trace events for hw/misc/ directory, Daniel P. Berrange, 2016/06/09