[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 04/11] nbd: Improve server handling of bogus
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v4 04/11] nbd: Improve server handling of bogus commands |
Date: |
Wed, 15 Jun 2016 00:05:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 14/06/2016 17:59, Alex Bligh wrote:
>
>> On 14 Jun 2016, at 16:11, Paolo Bonzini <address@hidden> wrote:
>>
>>> To illustrate the problem, look consider what qemu itself would do as
>>> a server if it can't buffer the entire read issued to it.
>>
>> Return ENOMEM?
>
> Well OK, qemu then 'works' on the basis it breaks another
> part of the spec, which is coping with long reads.
ENOMEM is a documented error code, and the limits extension will help
with that as well.
>> However, it looks like the
>> de facto status prior to structured replies is that the error is in the
>> spec, and this patch introduces a regression.
>
> Well, I guess the patch makes it work the same as the
> reference server implementation and the spec, which I'd
> consider a fix. My view is that the error is in the
> kernel client.
... and QEMU and BSD. What good is a server that doesn't interoperate
(albeit only in error cases) with any client?
Paolo
- Re: [Qemu-devel] [PATCH v4 04/11] nbd: Improve server handling of bogus commands, Paolo Bonzini, 2016/06/13
- Re: [Qemu-devel] [PATCH v4 04/11] nbd: Improve server handling of bogus commands, Eric Blake, 2016/06/13
- Re: [Qemu-devel] [Nbd] [PATCH v4 04/11] nbd: Improve server handling of bogus commands, Wouter Verhelst, 2016/06/15
- Re: [Qemu-devel] [Nbd] [PATCH v4 04/11] nbd: Improve server handling of bogus commands, Wouter Verhelst, 2016/06/15
- Re: [Qemu-devel] [Nbd] [PATCH v4 04/11] nbd: Improve server handling of bogus commands, Alex Bligh, 2016/06/15
- Re: [Qemu-devel] [Nbd] [PATCH v4 04/11] nbd: Improve server handling of bogus commands, Paolo Bonzini, 2016/06/15
- Re: [Qemu-devel] [Nbd] [PATCH v4 04/11] nbd: Improve server handling of bogus commands, Alex Bligh, 2016/06/15
- Re: [Qemu-devel] [Nbd] [PATCH v4 04/11] nbd: Improve server handling of bogus commands, Paolo Bonzini, 2016/06/15
- Re: [Qemu-devel] [Nbd] [PATCH v4 04/11] nbd: Improve server handling of bogus commands, Wouter Verhelst, 2016/06/15
- Re: [Qemu-devel] [Nbd] [PATCH v4 04/11] nbd: Improve server handling of bogus commands, Wouter Verhelst, 2016/06/15