[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/9] mirror: improve performance of mirroring of
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 5/9] mirror: improve performance of mirroring of empty disk |
Date: |
Tue, 14 Jun 2016 21:20:47 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 06/14/2016 09:25 AM, Denis V. Lunev wrote:
> We should not take into account zero blocks for delay calculations.
> They are not read and thus IO throttling is not required. In the
> other case VM migration with 16 Tb QCOW2 disk with 4 Gb of data takes
> days.
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Fam Zheng <address@hidden>
> CC: Kevin Wolf <address@hidden>
> CC: Max Reitz <address@hidden>
> CC: Jeff Cody <address@hidden>
> CC: Eric Blake <address@hidden>
> ---
> block/mirror.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Seems reasonable, but I'll let others more familiar with throttling give
the final say.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 2/9] mirror: create mirror_dirty_init helper for mirror_run, (continued)
- [Qemu-devel] [PATCH 2/9] mirror: create mirror_dirty_init helper for mirror_run, Denis V. Lunev, 2016/06/14
- [Qemu-devel] [PATCH 6/9] block: pass qiov into before_write notifier, Denis V. Lunev, 2016/06/14
- [Qemu-devel] [PATCH 7/9] mirror: allow to save buffer for QEMUIOVector in MirrorOp, Denis V. Lunev, 2016/06/14
- [Qemu-devel] [PATCH 5/9] mirror: improve performance of mirroring of empty disk, Denis V. Lunev, 2016/06/14
- Re: [Qemu-devel] [PATCH 5/9] mirror: improve performance of mirroring of empty disk,
Eric Blake <=
- Re: [Qemu-devel] [PATCH 5/9] mirror: improve performance of mirroring of empty disk, Stefan Hajnoczi, 2016/06/15
- Re: [Qemu-devel] [PATCH 5/9] mirror: improve performance of mirroring of empty disk, Denis V. Lunev, 2016/06/15
- Re: [Qemu-devel] [PATCH 5/9] mirror: improve performance of mirroring of empty disk, Stefan Hajnoczi, 2016/06/16
- Re: [Qemu-devel] [PATCH 5/9] mirror: improve performance of mirroring of empty disk, Eric Blake, 2016/06/16
- Re: [Qemu-devel] [PATCH 5/9] mirror: improve performance of mirroring of empty disk, Stefan Hajnoczi, 2016/06/17
[Qemu-devel] [PATCH 9/9] mirror: replace bdrv_dirty_bitmap with plain hbitmap, Denis V. Lunev, 2016/06/14
[Qemu-devel] [PATCH 8/9] mirror: use synch scheme for drive mirror, Denis V. Lunev, 2016/06/14