[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] intel_iommu: Throw hw_error on notify_start
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] intel_iommu: Throw hw_error on notify_started |
Date: |
Thu, 16 Jun 2016 11:12:55 +1000 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Wed, Jun 15, 2016 at 09:56:16AM -0600, Alex Williamson wrote:
> We don't currently support the MemoryRegionIOMMUOps notifier, so throw
> an error should a device require it.
>
> Signed-off-by: Alex Williamson <address@hidden>
Reviewed-by: David Gibson <address@hidden>
> ---
> hw/i386/intel_iommu.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> index 347718f..5eba704 100644
> --- a/hw/i386/intel_iommu.c
> +++ b/hw/i386/intel_iommu.c
> @@ -24,6 +24,7 @@
> #include "exec/address-spaces.h"
> #include "intel_iommu_internal.h"
> #include "hw/pci/pci.h"
> +#include "hw/pci/pci_bus.h"
>
> /*#define DEBUG_INTEL_IOMMU*/
> #ifdef DEBUG_INTEL_IOMMU
> @@ -1871,6 +1872,16 @@ static IOMMUTLBEntry vtd_iommu_translate(MemoryRegion
> *iommu, hwaddr addr,
> return ret;
> }
>
> +static void vtd_iommu_notify_started(MemoryRegion *iommu)
> +{
> + VTDAddressSpace *vtd_as = container_of(iommu, VTDAddressSpace, iommu);
> +
> + hw_error("Device at bus %s addr %02x.%d requires iommu notifier which "
> + "is currently not supported by intel-iommu emulation",
> + vtd_as->bus->qbus.name, PCI_SLOT(vtd_as->devfn),
> + PCI_FUNC(vtd_as->devfn));
> +}
> +
> static const VMStateDescription vtd_vmstate = {
> .name = "iommu-intel",
> .unmigratable = 1,
> @@ -1938,6 +1949,7 @@ static void vtd_init(IntelIOMMUState *s)
> memset(s->womask, 0, DMAR_REG_SIZE);
>
> s->iommu_ops.translate = vtd_iommu_translate;
> + s->iommu_ops.notify_started = vtd_iommu_notify_started;
> s->root = 0;
> s->root_extended = false;
> s->dmar_enabled = false;
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH 0/2] memory/intel_iommu: Generate error for incompatible usage, Alex Williamson, 2016/06/15
- [Qemu-devel] [PATCH 1/2] memory: Add MemoryRegionIOMMUOps.notify_started/stopped callbacks, Alex Williamson, 2016/06/15
- [Qemu-devel] [PATCH 2/2] intel_iommu: Throw hw_error on notify_started, Alex Williamson, 2016/06/15
- Re: [Qemu-devel] [PATCH 0/2] memory/intel_iommu: Generate error for incompatible usage, Alexey Kardashevskiy, 2016/06/15
- Re: [Qemu-devel] [PATCH 0/2] memory/intel_iommu: Generate error for incompatible usage, Peter Xu, 2016/06/15
- Re: [Qemu-devel] [PATCH 0/2] memory/intel_iommu: Generate error for incompatible usage, Alex Williamson, 2016/06/28