[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 14/17] block: Switch transfer length bounds t
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 14/17] block: Switch transfer length bounds to byte-based |
|
Date: |
Thu, 16 Jun 2016 13:42:11 +0800 |
|
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Tue, 06/14 15:30, Eric Blake wrote:
> Sector-based limits are awkward to think about; in our on-going
> quest to move to byte-based interfaces, convert max_transfer_length
> and opt_transfer_length. Rename them (dropping the _length suffix)
> so that the compiler will help us catch the change in semantics
> across any rebased code, and improve the documentation. Use unsigned
> values, so that we don't have to worry about negative values and
> so that bit-twiddling is easier; however, we are still constrained
> by 2^31 of signed int in most APIs.
>
> Signed-off-by: Eric Blake <address@hidden>
Looks good apart from the scsi-generic blocksize calculation, which is not an
issue of this patch.
Reviewed-by: Fam Zheng <address@hidden>
[Qemu-devel] [PATCH v2 17/17] block: Move request_alignment into BlockLimit, Eric Blake, 2016/06/14
[Qemu-devel] [PATCH v2 14/17] block: Switch transfer length bounds to byte-based, Eric Blake, 2016/06/14
[Qemu-devel] [PATCH v2 09/17] iscsi: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/14
[Qemu-devel] [PATCH v2 16/17] block: Split bdrv_merge_limits() from bdrv_refresh_limits(), Eric Blake, 2016/06/14
[Qemu-devel] [PATCH v2 08/17] blkdebug: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/14