Re: [Qemu-devel] [PATCH v2 37/40] trace: split out trace events for target-s390x/ directory

[Cornelia Huck]

On Thu, 16 Jun 2016 09:40:23 +0100
"Daniel P. Berrange" <address@hidden> wrote:

> Move all trace-events for files in the target-s390x/ directory to
> their own file.
> 
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  Makefile.objs             |  1 +
>  target-s390x/trace-events | 21 +++++++++++++++++++++
>  trace-events              | 21 ---------------------
>  3 files changed, 22 insertions(+), 21 deletions(-)
>  create mode 100644 target-s390x/trace-events
> 

> diff --git a/target-s390x/trace-events b/target-s390x/trace-events
> new file mode 100644
> index 0000000..d847814
> --- /dev/null
> +++ b/target-s390x/trace-events
> @@ -0,0 +1,21 @@
> +# See docs/trace-events.txt for syntax documentation.
> +
> +# target-s390x/mmu_helper.c
> +get_skeys_nonzero(int rc) "SKEY: Call to get_skeys unexpectedly returned %d"
> +set_skeys_nonzero(int rc) "SKEY: Call to set_skeys unexpectedly returned %d"
> +
> +# target-s390x/ioinst.c
> +ioinst(const char *insn) "IOINST: %s"
> +ioinst_sch_id(const char *insn, int cssid, int ssid, int schid) "IOINST: %s 
> (%x.%x.%04x)"
> +ioinst_chp_id(const char *insn, int cssid, int chpid) "IOINST: %s (%x.%02x)"
> +ioinst_chsc_cmd(uint16_t cmd, uint16_t len) "IOINST: chsc command %04x, len 
> %04x"

Add a blank line?

> +# target-s390x/kvm.c
> +kvm_enable_cmma(int rc) "CMMA: enabling with result code %d"
> +kvm_clear_cmma(int rc) "CMMA: clearing with result code %d"
> +kvm_failed_cpu_state_set(int cpu_index, uint8_t state, const char *msg) 
> "Warning: Unable to set cpu %d state %" PRIu8 " to KVM: %s"
> +kvm_sigp_finished(uint8_t order, int cpu_index, int dst_index, int cc) 
> "SIGP: Finished order %u on cpu %d -> cpu %d with cc=%d"
> +
> +# target-s390x/cpu.c
> +cpu_set_state(int cpu_index, uint8_t state) "setting cpu %d state to %" PRIu8
> +cpu_halt(int cpu_index) "halting cpu %d"
> +cpu_unhalt(int cpu_index) "unhalting cpu %d"

Otherwise,
Acked-by: Cornelia Huck <address@hidden>