[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 2/8] blockjob: rename block_job_is_paused()
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH v5 2/8] blockjob: rename block_job_is_paused() |
Date: |
Thu, 16 Jun 2016 17:56:23 +0100 |
The block_job_is_paused() function name is not great because callers
only use it to determine whether pausing has been requested. Rename it
to highlight those semantics and remove it from the public header file
as there are no external callers.
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
blockjob.c | 4 ++--
include/block/blockjob.h | 9 ---------
2 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/blockjob.c b/blockjob.c
index 463bccf..08ac430 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -252,7 +252,7 @@ void block_job_pause(BlockJob *job)
job->pause_count++;
}
-bool block_job_is_paused(BlockJob *job)
+static bool block_job_should_pause(BlockJob *job)
{
return job->pause_count > 0;
}
@@ -361,7 +361,7 @@ void block_job_sleep_ns(BlockJob *job, QEMUClockType type,
int64_t ns)
}
job->busy = false;
- if (block_job_is_paused(job)) {
+ if (block_job_should_pause(job)) {
qemu_coroutine_yield();
} else {
co_aio_sleep_ns(blk_get_aio_context(job->blk), type, ns);
diff --git a/include/block/blockjob.h b/include/block/blockjob.h
index 00ac418..8fcecf9 100644
--- a/include/block/blockjob.h
+++ b/include/block/blockjob.h
@@ -348,15 +348,6 @@ void block_job_event_completed(BlockJob *job, const char
*msg);
void block_job_event_ready(BlockJob *job);
/**
- * block_job_is_paused:
- * @job: The job being queried.
- *
- * Returns whether the job is currently paused, or will pause
- * as soon as it reaches a sleeping point.
- */
-bool block_job_is_paused(BlockJob *job);
-
-/**
* block_job_cancel_sync:
* @job: The job to be canceled.
*
--
2.5.5
- [Qemu-devel] [PATCH v5 0/8] blockjob: AioContext change support for mirror and backup, Stefan Hajnoczi, 2016/06/16
- [Qemu-devel] [PATCH v5 4/8] blockjob: add block_job_get_aio_context(), Stefan Hajnoczi, 2016/06/16
- [Qemu-devel] [PATCH v5 2/8] blockjob: rename block_job_is_paused(),
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v5 3/8] blockjob: add pause points, Stefan Hajnoczi, 2016/06/16
- [Qemu-devel] [PATCH v5 6/8] blockjob: add AioContext attached callback, Stefan Hajnoczi, 2016/06/16
- [Qemu-devel] [PATCH v5 1/8] blockjob: move iostatus reset out of block_job_enter(), Stefan Hajnoczi, 2016/06/16
- [Qemu-devel] [PATCH v5 8/8] backup: follow AioContext change gracefully, Stefan Hajnoczi, 2016/06/16
- [Qemu-devel] [PATCH v5 7/8] mirror: follow AioContext change gracefully, Stefan Hajnoczi, 2016/06/16
- [Qemu-devel] [PATCH v5 5/8] block: use safe iteration over AioContext notifiers, Stefan Hajnoczi, 2016/06/16
- Re: [Qemu-devel] [PATCH v5 0/8] blockjob: AioContext change support for mirror and backup, Paolo Bonzini, 2016/06/16
- Re: [Qemu-devel] [PATCH v5 0/8] blockjob: AioContext change support for mirror and backup, Stefan Hajnoczi, 2016/06/17