Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

[David Gibson]

On Fri, Jun 17, 2016 at 08:03:29AM +0200, Cédric Le Goater wrote:
> On 06/17/2016 07:54 AM, Cédric Le Goater wrote:
> > On 06/17/2016 04:27 AM, David Gibson wrote:
> >> On Thu, Jun 16, 2016 at 11:07:02AM +1000, David Gibson wrote:
> >>> On Mon, Jun 13, 2016 at 07:24:47AM +0200, Cédric Le Goater wrote:
> >>>> From: Benjamin Herrenschmidt <address@hidden>
> >>>>
> >>>> This reworks emulation of the various "rfi" variants. I removed
> >>>> some masking bits that I couldn't make sense of, the only bit that
> >>>> I am aware we should mask here is POW, the CPU's MSR mask should
> >>>> take care of the rest.
> >>>>
> >>>> This also fixes some problems when running 32-bit userspace under
> >>>> a 64-bit kernel.
> >>>>
> >>>> Signed-off-by: Benjamin Herrenschmidt <address@hidden>
> >>>> Reviewed-by: David Gibson <address@hidden>
> >>>
> >>> I've merged this patch to ppc-for-2.7.
> >>
> >> ..and now I've removed it again.  It seems that this breaks Thomas'
> >> new test that OpenBIOS runs on the mac machine types.  Not sure why,
> >> but we need to figure that out before I apply.
> > 
> > Just this patch ? I booted a macosx image with it. but maybe just a mac99.
> > I will check today.
> 
> With your branch ppc-for-2.7 (at commit aba2e6258d86) + the 
> "ppc: Fix rfi/rfid/hrfi/... emulation" patch, these guests : 
> 
>       qemu-system-ppc -cdrom ./darwinppc-602.cdr -boot d 
>       qemu-system-ppc -M mac99 -cdrom ./darwinppc-602.cdr -boot d 
> 
> reach the installer macosx installer.

But the prom-env-test from make check fails :(.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature