[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/3] potentially broken drive-mirror/drive-ba
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 0/3] potentially broken drive-mirror/drive-backup in bdrv_co_discard |
|
Date: |
Fri, 17 Jun 2016 13:25:58 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 16.06.2016 um 18:09 hat Denis V. Lunev geschrieben:
> Actually I have found this problem running iotest 132 for active async
> mirror I have sent yesturday. Anyway, the problem is actual for current
> backup/mirror implementation.
>
> bdrv_co_discard must mark areas dirty after writing zeroes, it must call
> before_write_notifier chain to push underlying data to backup and it also
> must properly fill tracked request information.
>
> Changes from v1:
> - fixed problem in patch as pointed out by Vova
> - ported to current (was made on top of active block mirror)
> - minor spelling changes in commit messages
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> Reviewed-by: Vladimir Sementsov-Ogievskiy<address@hidden>
> Reviewed-by: Fam Zheng <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Kevin Wolf <address@hidden>
> CC: Max Reitz <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>