[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 13/13] vmstate-static-checker: fix size mismatch dete
From: |
Amit Shah |
Subject: |
[Qemu-devel] [PULL 13/13] vmstate-static-checker: fix size mismatch detection in unused fields |
Date: |
Fri, 17 Jun 2016 18:36:52 +0530 |
If a field changed from something to unused, the checker wasn't flagging
if the field size mismatched. This was noticed in:
http://thread.gmane.org/gmane.comp.emulators.qemu/419802
where the 4->1 size change along with field name change to 'unused'
wasn't being flagged. Fix this.
Signed-off-by: Amit Shah <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
---
scripts/vmstate-static-checker.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/vmstate-static-checker.py
b/scripts/vmstate-static-checker.py
index b5ecaf6..14a27e7 100755
--- a/scripts/vmstate-static-checker.py
+++ b/scripts/vmstate-static-checker.py
@@ -185,7 +185,7 @@ def check_fields(src_fields, dest_fields, desc, sec):
if unused_count == 0:
advance_dest = True
- if unused_count > 0:
+ if unused_count != 0:
if advance_dest == False:
unused_count = unused_count - s_item["size"]
if unused_count == 0:
--
2.7.4
- [Qemu-devel] [PULL 04/13] migration: Fix multi-thread compression bug, (continued)
- [Qemu-devel] [PULL 04/13] migration: Fix multi-thread compression bug, Amit Shah, 2016/06/17
- [Qemu-devel] [PULL 03/13] migration: fix inability to save VM after snapshot, Amit Shah, 2016/06/17
- [Qemu-devel] [PULL 06/13] migration: remove useless code, Amit Shah, 2016/06/17
- [Qemu-devel] [PULL 08/13] migration: refine ram_save_compressed_page, Amit Shah, 2016/06/17
- [Qemu-devel] [PULL 07/13] qemu-file: Fix qemu_put_compression_data flaw, Amit Shah, 2016/06/17
- [Qemu-devel] [PULL 05/13] migration: Fix a potential issue, Amit Shah, 2016/06/17
- [Qemu-devel] [PULL 09/13] migration: protect the quit flag by lock, Amit Shah, 2016/06/17
- [Qemu-devel] [PULL 11/13] migration: refine the decompression code, Amit Shah, 2016/06/17
- [Qemu-devel] [PULL 10/13] migration: refine the compression code, Amit Shah, 2016/06/17
- [Qemu-devel] [PULL 12/13] migration: code clean up, Amit Shah, 2016/06/17
- [Qemu-devel] [PULL 13/13] vmstate-static-checker: fix size mismatch detection in unused fields,
Amit Shah <=
- Re: [Qemu-devel] [PULL 00/13] migration: many fixes, Peter Maydell, 2016/06/17