[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/13] pc_q35: configure Q35 instance using prop
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 06/13] pc_q35: configure Q35 instance using properties |
Date: |
Fri, 17 Jun 2016 15:20:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 17/06/2016 15:11, Efimov Vasily wrote:
> Currently, Q35 instance is configured using direct access to structure fields.
> The patch uses property interface to set the fields.
>
> Signed-off-by: Efimov Vasily <address@hidden>
> ---
> hw/i386/pc_q35.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index 04aae89..d7dc23a 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -159,12 +159,18 @@ static void pc_q35_init(MachineState *machine)
> q35_host = Q35_HOST_DEVICE(qdev_create(NULL, TYPE_Q35_HOST_DEVICE));
>
> object_property_add_child(qdev_get_machine(), "q35", OBJECT(q35_host),
> NULL);
> - q35_host->mch.ram_memory = ram_memory;
> - q35_host->mch.pci_address_space = pci_memory;
> - q35_host->mch.system_memory = get_system_memory();
> - q35_host->mch.address_space_io = system_io;
> - q35_host->mch.below_4g_mem_size = pcms->below_4g_mem_size;
> - q35_host->mch.above_4g_mem_size = pcms->above_4g_mem_size;
> + object_property_set_link(OBJECT(q35_host), OBJECT(ram_memory),
> + MCH_HOST_PROP_RAM_MEM, NULL);
> + object_property_set_link(OBJECT(q35_host), OBJECT(pci_memory),
> + MCH_HOST_PROP_PCI_MEM, NULL);
> + object_property_set_link(OBJECT(q35_host), OBJECT(get_system_memory()),
> + MCH_HOST_PROP_SYSTEM_MEM, NULL);
> + object_property_set_link(OBJECT(q35_host), OBJECT(system_io),
> + MCH_HOST_PROP_IO_MEM, NULL);
> + object_property_set_int(OBJECT(q35_host), pcms->below_4g_mem_size,
> + PCI_HOST_BELOW_4G_MEM_SIZE, NULL);
> + object_property_set_int(OBJECT(q35_host), pcms->above_4g_mem_size,
> + PCI_HOST_ABOVE_4G_MEM_SIZE, NULL);
> /* pci */
> qdev_init_nofail(DEVICE(q35_host));
> phb = PCI_HOST_BRIDGE(q35_host);
>
Reviewed-by: Paolo Bonzini <address@hidden>
- [Qemu-devel] [PATCH 09/13] ICH9 SMB: make TYPE_ICH9_SMB_DEVICE macro public, (continued)
- [Qemu-devel] [PATCH 09/13] ICH9 SMB: make TYPE_ICH9_SMB_DEVICE macro public, Efimov Vasily, 2016/06/17
- [Qemu-devel] [PATCH 04/13] pflash: make TYPE_CFI_PFLASH0{1, 2} macros public, Efimov Vasily, 2016/06/17
- [Qemu-devel] [PATCH 02/13] pcspk: convert "pit" property type from ptr to link, Efimov Vasily, 2016/06/17
- [Qemu-devel] [PATCH 01/13] ide: move headers to include folder, Efimov Vasily, 2016/06/17
- [Qemu-devel] [PATCH 06/13] pc_q35: configure Q35 instance using properties, Efimov Vasily, 2016/06/17
- Re: [Qemu-devel] [PATCH 06/13] pc_q35: configure Q35 instance using properties,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 13/13] ICH9 LPC: configure PCI IRQs routing internally, Efimov Vasily, 2016/06/17
- [Qemu-devel] [PATCH 11/13] ICH9 LPC: move call of isa_bus_irqs to 'realize' method, Efimov Vasily, 2016/06/17
[Qemu-devel] [PATCH 08/13] port92: handle A20 IRQ as GPIO, Efimov Vasily, 2016/06/17
[Qemu-devel] [PATCH 07/13] pckbd: handle A20 IRQ as GPIO, Efimov Vasily, 2016/06/17