[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 4/6] trace: Add per-vCPU tracing states for e
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v4 4/6] trace: Add per-vCPU tracing states for events with the 'vcpu' property |
Date: |
Fri, 17 Jun 2016 16:24:32 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Tue, Jun 14, 2016 at 03:11:12PM +0200, Lluís Vilanova wrote:
> @@ -1116,6 +1117,7 @@ int main(int argc, char **argv)
> gdbserver_start (gdbstub_port);
> gdb_handlesig(cpu, 0);
> }
> + trace_init_vcpu_events();
Do vcpu events make sense in *-user builds? I thought this feature is
only available in *-softmmu.
> +######################################################################
> +# Avoid rule overrides when included from multiple top-level variables
> +ifndef MAKEFILE_GUARD_TRACE
> +MAKEFILE_GUARD_TRACE = 1
> +endif
Are you including this makefile multiple times? We need to find a
cleaner solution. If this is related to "stubs", then could
control-stub.o could go in stubs/?
signature.asc
Description: PGP signature
[Qemu-devel] [PATCH v4 6/6] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state, Lluís Vilanova, 2016/06/14
Re: [Qemu-devel] [PATCH v4 6/6] trace: Add QAPI/QMP interfaces to query and control per-vCPU tracing state, Lluís Vilanova, 2016/06/20