[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 1/7] cpu: move break/watchpoints into arrays.
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC 1/7] cpu: move break/watchpoints into arrays. |
Date: |
Fri, 17 Jun 2016 19:03:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 17/06/2016 18:33, Alex Bennée wrote:
> Before we can protect the lists we need a structure a little more
> amenable to RCU protection. This moves all the lists into a re-sizeable
> array. The array still only points to allocated structures because a
> number of the architectures still need to look at the results of a hit
> by examining the field.
>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
> cpu-exec.c | 6 +-
> exec.c | 167
> ++++++++++++++++++++++++++++++---------------
Can you look into moving this to cpu-exec.c? (or cpu-exec-common.c
perhaps?) It's TCG only, so it doesn't really belong in exec.c if we
can help it.
Paolo
> include/qom/cpu.h | 22 +++---
> linux-user/main.c | 22 +++---
> qom/cpu.c | 2 -
> target-arm/translate-a64.c | 6 +-
> target-arm/translate.c | 6 +-
> target-i386/bpt_helper.c | 6 +-
> target-lm32/helper.c | 6 +-
> 9 files changed, 157 insertions(+), 86 deletions(-)
- [Qemu-devel] [RFC 0/7] Safe watch and breakpoint manipulation, Alex Bennée, 2016/06/17
- [Qemu-devel] [RFC 1/7] cpu: move break/watchpoints into arrays., Alex Bennée, 2016/06/17
- Re: [Qemu-devel] [RFC 1/7] cpu: move break/watchpoints into arrays.,
Paolo Bonzini <=
- [Qemu-devel] [RFC 5/7] breakpoints: put breakpoints under RCU control, Alex Bennée, 2016/06/17
- [Qemu-devel] [RFC 3/7] exec: keep CPUBreakpoint references internal, Alex Bennée, 2016/06/17
- [Qemu-devel] [RFC 6/7] linux-user: don't clone watchpoints, Alex Bennée, 2016/06/17
- [Qemu-devel] [RFC 4/7] break/watchpoints: store inside array, Alex Bennée, 2016/06/17
- [Qemu-devel] [RFC 2/7] exec: keep CPUWatchpoint references internal, Alex Bennée, 2016/06/17
- [Qemu-devel] [RFC 7/7] watchpoints: put watchpoints under RCU control, Alex Bennée, 2016/06/17