[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] alpha: Fix build error for linux-user
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] alpha: Fix build error for linux-user |
|
Date: |
Fri, 17 Jun 2016 11:09:45 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 06/17/2016 11:07 AM, Pranith Kumar wrote:
> On Fri, Jun 17, 2016 at 2:04 PM, Paolo Bonzini <address@hidden> wrote:
>>
>>
>> On 16/06/2016 21:07, Richard Henderson wrote:
>>>> && ((addr >> 41) & 3) == 2
>>>> - && addr >> TARGET_VIRT_ADDR_SPACE_BITS == addr >> 63);
>>>> + && addr >> TARGET_VIRT_ADDR_SPACE_BITS == 1);
>>
>> What you want here is
>>
>> + addr >> TARGET_VIRT_ADDR_SPACE_BITS == -1
>>
>> since that's what addr >> 63 is. With this change the patch should be fine.
>
> Isn't (addr >> 63) supposed to be 1? How can it be -1?
Signed right shift.
I'll prepare a patch for all of this.
r~