[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 5/7] log: Plug memory leak on multiple -dfilter
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 5/7] log: Plug memory leak on multiple -dfilter |
Date: |
Mon, 20 Jun 2016 17:00:21 +0200 |
-dfilter overwrites any previous filter. The overwritten filter is
leaked. Leaks since the beginning (commit 3514552, v2.6.0). Free it
properly.
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
util/log.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/util/log.c b/util/log.c
index 5ad72c1..6f45e0a 100644
--- a/util/log.c
+++ b/util/log.c
@@ -145,9 +145,16 @@ bool qemu_log_in_addr_range(uint64_t addr)
void qemu_set_dfilter_ranges(const char *filter_spec)
{
gchar **ranges = g_strsplit(filter_spec, ",", 0);
+
+ if (debug_regions) {
+ g_array_unref(debug_regions);
+ debug_regions = NULL;
+ }
+
if (ranges) {
gchar **next = ranges;
gchar *r = *next++;
+
debug_regions = g_array_sized_new(FALSE, FALSE,
sizeof(Range),
g_strv_length(ranges));
while (r) {
--
2.5.5
- [Qemu-devel] [PULL 0/7] Error reporting patches for 2016-06-20, Markus Armbruster, 2016/06/20
- [Qemu-devel] [PULL 1/7] vl: Error messages need to go to stderr, fix some, Markus Armbruster, 2016/06/20
- [Qemu-devel] [PULL 3/7] error: Remove unnecessary local_err variables, Markus Armbruster, 2016/06/20
- [Qemu-devel] [PULL 5/7] log: Plug memory leak on multiple -dfilter,
Markus Armbruster <=
- [Qemu-devel] [PULL 7/7] log: Fix qemu_set_log_filename() error handling, Markus Armbruster, 2016/06/20
- [Qemu-devel] [PULL 4/7] coccinelle: Remove unnecessary variables for function return value, Markus Armbruster, 2016/06/20
- [Qemu-devel] [PULL 2/7] error: Remove NULL checks on error_propagate() calls, Markus Armbruster, 2016/06/20
- [Qemu-devel] [PULL 6/7] log: Fix qemu_set_dfilter_ranges() error reporting, Markus Armbruster, 2016/06/20
- Re: [Qemu-devel] [PULL 0/7] Error reporting patches for 2016-06-20, Peter Maydell, 2016/06/20