Re: [Qemu-devel] [RFC PATCH] Change g_source_attach(xx, NULL) to g_souce_attach(xx, g_main_context_get_thread_default())

[Zhang Chen]

On 06/21/2016 12:45 AM, Eric Blake wrote:
> On 06/20/2016 02:23 AM, Zhang Chen wrote:
>
> Subject line is too long, missing a 'topic:' prefix, and has a typo
> (souce).  Suggest:
>
> qemu-char: Fix context for g_source_attach()

OK~~ I will fix it in next version.

> > We want to poll and handle chardev in another thread
> > other than main loop. But qemu_chr_add_handlers() can only
> > work for global default context other than thread default context.
> > So we use g_souce_attach(xx, g_main_context_get_thread_default())
> s/souce/source/

will fix...

> > replace g_source_attach(xx, NULL) to attach g_source.
> > Comments form jason.
> s/form/from/ ?

Yes...will fix in next version.

Thanks
Zhang　Chen

> > Signed-off-by: Zhang Chen <address@hidden>
> > Signed-off-by: Jason Wang <address@hidden>
> > ---
> >   io/channel.c | 2 +-
> >   qemu-char.c  | 6 +++---
> >   2 files changed, 4 insertions(+), 4 deletions(-)

--
Thanks
zhangchen