Re: [Qemu-devel] [PATCH 04/15] block: Simplify find_block_job() and make it accept a job ID

[Alberto Garcia]

On Mon 20 Jun 2016 06:40:31 PM CEST, Max Reitz wrote:

>> +        error_setg(errp, "Block job '%s' not found", id ? id : device);
>
> This changes the error class if device is set. Not sure if that is
> bad, but keeping the old behavior should be simple (unless you're sure
> it's fine).

You're right, I'll fix it.

> Also, but this is a personal opinion, I'd make the error path more
> explicit, i.e.:
>
> if (!job) {
>     /* ... */
>     return NULL;
> }

Yeah, why not.

Berto