Re: [Qemu-devel] [PATCH v2 1/1] mirror: fix trace_mirror_yield_in_flight usage in mirror_iteration()

[Eric Blake]

On 06/21/2016 08:09 AM, Denis V. Lunev wrote:
> trace_mirror_yield_in_flight accepts 2nd arguments in sectors while here
> we pass chunks instead.
> 
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Jeff Cody <address@hidden>
> CC: Kevin Wolf <address@hidden>
> CC: Max Reitz <address@hidden>
> ---
> Changes from v1:
> - proper persons added to CC list
> 
>  block/mirror.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/mirror.c b/block/mirror.c
> index a04ed9c..930ac96 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -327,7 +327,7 @@ static uint64_t coroutine_fn 
> mirror_iteration(MirrorBlockJob *s)
>  
>      first_chunk = sector_num / sectors_per_chunk;
>      while (test_bit(first_chunk, s->in_flight_bitmap)) {
> -        trace_mirror_yield_in_flight(s, first_chunk, s->in_flight);
> +        trace_mirror_yield_in_flight(s, sector_num, s->in_flight);

Ultimately, it would be nice to fix the trace to use bytes instead of
sectors. But as a stopgap, this is obviously correct, so:

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature