Re: [Qemu-devel] [PATCH 04/13] virtio-scsi: Wrap in vmstate

[Cornelia Huck]

On Tue, 21 Jun 2016 20:13:58 +0100
"Dr. David Alan Gilbert (git)" <address@hidden> wrote:

> From: "Dr. David Alan Gilbert" <address@hidden>
> 
> Forcibly convert it to a vmstate wrapper;  proper conversion
> comes later.
> 
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
>  hw/scsi/virtio-scsi.c | 21 ++++++---------------
>  1 file changed, 6 insertions(+), 15 deletions(-)
> 
> diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
> index 71d09d3..6e518f4 100644
> --- a/hw/scsi/virtio-scsi.c
> +++ b/hw/scsi/virtio-scsi.c
> @@ -663,7 +663,7 @@ static void virtio_scsi_reset(VirtIODevice *vdev)
>  /* The device does not have anything to save beyond the virtio data.
>   * Request data is saved with callbacks from SCSI devices.
>   */
> -static void virtio_scsi_save(QEMUFile *f, void *opaque)
> +static void virtio_scsi_save(QEMUFile *f, void *opaque, size_t size)
>  {
>      VirtIODevice *vdev = VIRTIO_DEVICE(opaque);
>      VirtIOSCSI *s = VIRTIO_SCSI(vdev);
> @@ -674,16 +674,11 @@ static void virtio_scsi_save(QEMUFile *f, void *opaque)
>      virtio_save(vdev, f);
>  }

You'll be able to switch to the generic function once the patch
removing stopping dataplane has landed.

Reviewed-by: Cornelia Huck <address@hidden>