[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v3 PATCH 10/14] tcg/tci: Add support for fence
|
From: |
Sergey Fedorov |
|
Subject: |
Re: [Qemu-devel] [RFC v3 PATCH 10/14] tcg/tci: Add support for fence |
|
Date: |
Wed, 22 Jun 2016 23:28:32 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 |
On 22/06/16 23:25, Richard Henderson wrote:
> On 06/22/2016 12:57 PM, Sergey Fedorov wrote:
>>>> @@ -1236,6 +1236,9 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env,
>>>> uint8_t *tb_ptr)
>>>> tcg_abort();
>>>> }
>>>> break;
>>>> + case INDEX_op_mb:
>>>> + smp_mb();
>> I think we could distinguish smp_rmb(), smp_wmb() and smp_mb() here.
> I don't. The extra unpredictable branch is not likely to be worthwhile.
>
> If we want anything finer grained for tci, would should revisit the complete
> rewrite that I did a year to two ago.
>
Fair enough.
Thanks,
Sergey