[Qemu-devel] [Bug 1393486] Re: hw/virtio/virtio-rng.c:150: bad test ?

[T. Huth]

Fixed here:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=a3a292c420d2fec3c07

** Changed in: qemu
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1393486

Title:
  hw/virtio/virtio-rng.c:150: bad test ?

Status in QEMU:
  Fix Released

Bug description:
  hw/virtio/virtio-rng.c:150:31: warning: logical not is only applied to
  the left hand side of comparison [-Wlogical-not-parentheses]

      if (!vrng->conf.period_ms > 0) {
          error_setg(errp, "'period' parameter expects a positive integer");
          return;
      }

  Maybe better code

      if (vrng->conf.period_ms <= 0) {
          error_setg(errp, "'period' parameter expects a positive integer");
          return;
      }

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1393486/+subscriptions