Re: [Qemu-devel] [PATCH 05/12] monitor: register the qapi generated commands

[Marc-André Lureau]

Hi

----- Original Message -----
> 
> 
> On 23/06/2016 02:08, address@hidden wrote:
> > 
> > Stop using the so-called 'middle' mode. Instead, use qmp_find_command()
> > from generated qapi commands registry.
> > 
> > Note: this commit requires a 'make clean' prior to make, since the
> > generated files do not depend on Makefile (due to a cyclic rule
> > introduced in 4115852bb0).
> > 
> > Signed-off-by: Marc-André Lureau <address@hidden>
> 
> What is the cyclic dependency?

We have in Makefile.target:

Makefile: $(GENERATED_HEADERS)

But we should also or rather have:

$(GENERATED_HEADERS) $(GENERATED_SOURCES): Makefile:

That would be cyclic.


I understand the first rule was added to simplify the dependencies and make 
sure the generated files are done prior to any building. But it sounds like 
it's not a conventional way to write your rules and prevent proper dependencies.

Do you know another trick we could use for the generated files?

regards