[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/10] machine: Skip global registration for
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 10/10] machine: Skip global registration for non-existing classes |
|
Date: |
Thu, 23 Jun 2016 08:32:11 -0300 |
|
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Thu, Jun 23, 2016 at 10:26:49AM +0200, Markus Armbruster wrote:
> Eduardo Habkost <address@hidden> writes:
>
> > MachineClass::compat_props may point to class names that are not
> > compiled into the QEMU binary. Skip registering those as global
> > properties. This will allow the qdev global property code to
> > implement stricter checks on the global property values in the
> > future.
> >
> > Signed-off-by: Eduardo Habkost <address@hidden>
>
> Not sure what those stricter checks might be, but that's okay.
>
> Doesn't this suppress detection of programming errors? Say I fat-finger
> a device name in my machine type's global properties.
We can't detect that, because compat_props is allowed to include
classes that are disabled at build time.
> Before this patch, I get an error (a nice one since PATCH 06).
You don't. The class name validation in qdev_prop_check_globals()
is done only on user-provided properties.
--
Eduardo