Re: [Qemu-devel] [PATCH v2] Improve the alignment check infrastructure

[Sergey Sorokin]

   A

   A

   23.06.2016, 17:05, "Richard Henderson" <address@hidden>:

     On 06/23/2016 03:03 AM, Sergey Sorokin wrote:

     A So what's wrong in this part of the patch?

     I think I just misread it.

   A

   It happens :)

   A

   A
   22.06.2016, 18:50, "Richard Henderson" <address@hidden>:

     On 06/22/2016 05:37 AM, Sergey Sorokin wrote:

     A +/* Use this mask to check interception with an alignment mask
     A + * in a TCG backend.
     A + */
     A +#define TLB_FLAGS_MASK (TLB_INVALID_MASK | TLB_NOTDIRTY |
     TLB_MMIO)

     I think we ought to check this in tcg-op.c, rather than wait until
     generating
     code in the backend.

   I think it's better to check this in one place in get_alignment_bits()
   function
   because there can be a direct call of helpers from softmmu_template.h.