Re: [Qemu-devel] [PATCH RFC 2/5] tests: New make target check-headers

[Peter Maydell]

On 23 June 2016 at 17:40, Paolo Bonzini <address@hidden> wrote:
> On 23/06/2016 18:12, Markus Armbruster wrote:
>> For each header "FOO.h", the test checks whether
>>
>>       #include "qemu/osdep.h"
>>       #include "FOO.h"
>>       #include "FOO.h"
>>
>> compiles.  A large number of headers don't pass this test, by design
>> or by accident.  These are all excluded with a blacklist for now.  Add
>> make target check-blacklisted-headers to help with examinating how
>> they fail.
>
> Can we replace the blacklist with a fixed-format /* FIXME */ comment?

Ooh. I was going to suggest moving the blacklist into its own
file, but a magic comment is a better idea, less chance of
merge conflicts.

Rather than listing "check-headers" specifically in the help,
I suggest we have a more generic "check-source" for running
code style/etc checks on the sources (of which check-headers
is the only one at first). Then we have a good place to put
new style type checks in future without requiring everybody
to change the command lines they're using to invoke them.

thanks
-- PMM