|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [RFC v3 PATCH 04/14] tcg/arm: Add support for fence |
Date: | Thu, 23 Jun 2016 09:49:28 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 06/23/2016 09:30 AM, Alex Bennée wrote:
Pranith Kumar <address@hidden> writes:Cc: Andrzej Zaborowski <address@hidden> Cc: Peter Maydell <address@hidden> Signed-off-by: Pranith Kumar <address@hidden> Signed-off-by: Richard Henderson <address@hidden> --- tcg/arm/tcg-target.inc.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c index f9f54c6..1447aa8 100644 --- a/tcg/arm/tcg-target.inc.c +++ b/tcg/arm/tcg-target.inc.c @@ -313,6 +313,10 @@ typedef enum { INSN_LDRD_REG = 0x000000d0, INSN_STRD_IMM = 0x004000f0, INSN_STRD_REG = 0x000000f0, + + INSN_DMB_ISH = 0x5bf07ff5, + INSN_DMB_MCR = 0xba0f07ee,Again I think you might want to split the instruction encoding. Also where did you get these encoding from? Is it right the byte-order has been reversed if it is being written out by endian aware helpers?
I don't think there's any point in separating out ISH, or all the parts of the MCR move.
As for the endianness... I must have read the number out of objdump incorrectly. r~
[Prev in Thread] | Current Thread | [Next in Thread] |